Hi Kukjin, On Fri, Feb 1, 2013 at 3:56 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > Tomasz Figa wrote: >> >> Hi Vivek, > > [...] > >> > + usb@12120000 { >> > + compatible = "samsung,exynos4210-ohci"; >> > + reg = <0x12120000 0x100>; >> > + interrupts = <0 71 0>; >> >> For Samsung platforms we decided per board enabling of nodes and so this >> node should also contain: >> >> status = "disabled"; >> >> while in dts file of board using ohci there would be an overriding entry: >> >> usb@12120000 { >> status = "okay"; >> }; >> >> I know that Exynos5250 has not been yet converted into this convention, >> but using it when adding new devices will simplify the process. >> > Well, I have another opinion on this... > > Let's see, yeah, we are using following method in EXYNOS4 DT... > - disabling IPs in SoC DT source and enabling IPs in board DT source > > But as I said, in EXYNOS5440 DT, I want to use following, because most of > them should be enabled/used. > - enabling IPs in SoC DT source and no need enabling in board DT source. > > I mean, it depends on each SoC's situation. > So, since USB 2.0 (EHCI/OHCI) shall be always enabled on almost all the boards, so we shall keep it enabled in SOC DT source. In that case following patches can be picked for a merge: [PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver http://www.mail-archive.com/linux-usb@xxxxxxxxxxxxxxx/msg12330.html [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver http://www.mail-archive.com/linux-usb@xxxxxxxxxxxxxxx/msg12266.html These will enable EHCI and OHCI support on exynos5250. Please let me know if you want me to resend them. ;-) -- Thanks & Regards Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html