Hi Kukjin, On Wed, Jan 30, 2013 at 10:36 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > Vivek Gautam wrote: >> >> Adding usbphy node for Exynos5250 along with the >> necessary device data to be parsed. >> >> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx> >> --- >> arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++++++++++ >> 1 files changed, 15 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi >> b/arch/arm/boot/dts/exynos5250.dtsi >> index 30485de..610e338 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -275,6 +275,21 @@ >> #size-cells = <0>; >> }; >> >> + usbphy@12130000 { > > Please put above node by order of address. > Sure will do that. Actually thought the listing was as per IPs. >> + compatible = "samsung,exynos5250-usbphy"; >> + reg = <0x12130000 0x100>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + >> + usbphy-sys { >> + /* USB device and host PHY_CONTROL registers > */ > > Please add the binding documentation instead of comment here. > Bindings documentation already added at "Documentation/devicetree/bindings/usb/samsung-usbphy.txt" merged in 'usb-next'. >> + reg = <0x10040704 0x8>, >> + /* USB2.0 PHY configuration register */ >> + <0x10050230 0x4>; >> + }; >> + }; >> + >> amba { >> #address-cells = <1>; >> #size-cells = <1>; >> -- >> 1.7.6.5 > -- Thanks & Regards Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html