Hi Sylwester, >> +Example: > > Maybe adding a comment that this is a SoC... > >> +mfc: codec@13400000 { >> + compatible = "samsung,mfc-v5"; >> + reg = <0x13400000 0x10000>; >> + interrupts = <0 94 0>; >> +}; > > and the board specific part would make it more clear ? Absolutely :) > >> +codec@13400000 { >> + samsung,mfc-r = <0x43000000 0x800000>; >> + samsung,mfc-l = <0x51000000 0x800000>; >> +}; > > Also please note that in the first node above you need > status = "disabled"; line, so the MFC is disabled by default. > Then in dts files for boards that use the codec it can be > overridden to enable the device as needed. Right. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html