Re: [PATCH 2/4] ARM: dts: add support for mixer to exynos4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 01/28/2013 07:44 AM, Rahul Sharma wrote:
+
+       mixer: mixer {
+               compatible = "samsung,exynos4-mixer";


I'm afraid this compatible property it too generic. Is the video mixer IP
really identical an all the Exynos4 series SoCs ?


It is same in Exynos4210, 4212 and 4412.


+               reg =<0x12c10000 0x10000>,
+<0x12c00000 0x10000>;
+               interrupts =<0 91 0>;
+               samsung,power-domain =<&pd_tv>;
+       };
   };


Is there documentation for these new bindings available somewhere ?


it is there at Documentation/devicetree/bindings/drm/exynos/mixer.txt.
Probably I need to add details for power domain node property.

Sorry, I can't see anything for Exynos4 there, it's only for exynos5 SoCs.
I think the need for the 'samsung,power-domain' property (I guess that
should be optional) needs to be documented for completeness.

Getting back to the bindings documentation,
Documentation/devicetree/bindings/drm/exynos/ seems not exactly right
place for me, but that's a minor issue. There is also a V4L2 driver
for the HDMI and TV output devices in drivers/media/platform/s5p-tv.
So Documentation/devicetree/bindings/video or
Documentation/devicetree/bindings/media might be a better home for that
bindings documentation. These IPs are not specific to DRM at all.

--

Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux