Hi, On Mon, Jan 28, 2013 at 8:17 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Friday 18 January 2013, Padmavathi Venna wrote: >> diff --git a/Documentation/devicetree/bindings/dma/arm-pl330.txt b/Documentation/devicetree/bindings/dma/arm-pl330.txt >> index 36e27d5..457a233 100644 >> --- a/Documentation/devicetree/bindings/dma/arm-pl330.txt >> +++ b/Documentation/devicetree/bindings/dma/arm-pl330.txt >> @@ -8,6 +8,8 @@ Required properties: >> - reg: physical base address of the controller and length of memory mapped >> region. >> - interrupts: interrupt number to the cpu. >> + - #dma-cells: must be at least 1. used to represent the number of integer >> + cells in the dmas property of client device. > > The wording 'at least' seems wrong here: that is what we use in the > generic DMA binding, but in the part that is specific to one > driver, I would expect to see > > - #dma-cells: must be <1> > > Since that is what this particular driver requires. Okey. I will change this. > >> Client drivers (device nodes requiring dma transfers from dev-to-mem or >> @@ -27,7 +30,7 @@ as shown below. >> [property name] = <[phandle of the dma controller] [dma request id]>; >> >> where 'dma request id' is the dma request number which is connected >> - to the client controller. The 'property name' is recommended to be >> - of the form <name>-dma-channel. >> + to the client controller. The 'property name' is 'dmas' as recommended >> + by the generic dma device tree binding helpers. > > s/recommended/required/ > > Also, the "dma-names" property is required as well. OK. I will add. Thanks Padma > > Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |