On 01/24/2013 12:21 PM, Alim Akhtar wrote: >> + >> + i2c@12CC0000 { >> + status = "disabled"; >> + }; >> + >> + i2c@12CD0000 { >> + status = "disabled"; >> + }; >> + >> + i2c@121D0000 { >> + status = "disabled"; >> + }; >> + > > Why to disable these i2c devices here? Any particular reason? > You can moves these to exynos5250.dtsi which is suppose to be common > for all the exynos5250 platforms. > Please see the exynos4.dtsi for reference. > Agreed. There was a discussion going on in [1] related to this. Since there was no consensus on that, I preferred to go with the current approach that is followed for other EXYNOS5250 based scripts. If it is agreed by Kukjin to move to Exynos4 style, then I can submit patches for that. [1] http://www.mail-archive.com/linux-samsung-soc@xxxxxxxxxxxxxxx/msg15013.html -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html