Hi Tushar, Just a couple of minor comments. On 24 January 2013 11:46, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote: > From: Girish K S <ks.giri@xxxxxxxxxxx> > > Arndale is a low cost board based on the Samsung Exynos5250 SoC. This > patch adds initial device tree support for this board. > > Signed-off-by: Girish K S <ks.giri@xxxxxxxxxxx> > Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx> > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/exynos5250-arndale.dts | 124 ++++++++++++++++++++++++++++++ > 2 files changed, 125 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/boot/dts/exynos5250-arndale.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 5ebb44f..60a9e52 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \ > exynos4210-trats.dtb \ > exynos4412-smdk4412.dtb \ > exynos5250-smdk5250.dtb \ > + exynos5250-arndale.dtb \ I think this entry could be moved one step up for maintaining alphabetical order. > exynos5250-snow.dtb \ > exynos5440-ssdk5440.dtb > dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \ > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts > new file mode 100644 > index 0000000..7504cf3 > --- /dev/null > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts > @@ -0,0 +1,124 @@ > +/* > + * Samsung's Exynos5250 based Arndale board device tree source > + * > + * Copyright (c) 2012 Samsung Electronics Co., Ltd. 2013? > + * http://www.samsung.com > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > +*/ > + > +/dts-v1/; > +/include/ "exynos5250.dtsi" > + > +/ { > + model = "Insignal Arndale evaluation board based on EXYNOS5250"; > + compatible = "insignal,arndale", "samsung,exynos5250"; > + > + memory { > + reg = <0x40000000 0x80000000>; > + }; > + > + chosen { > + bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC2,115200 init=/linuxrc"; This could be resticted only to console bootargs = "console=ttySAC2,115200"; > + }; > + > + i2c@12C60000 { > + status = "disabled"; > + }; > + > + i2c@12C70000 { > + status = "disabled"; > + }; > + > + i2c@12C80000 { > + status = "disabled"; > + }; > + > + i2c@12C90000 { > + status = "disabled"; > + }; > + > + i2c@12CA0000 { > + status = "disabled"; > + }; > + > + i2c@12CB0000 { > + status = "disabled"; > + }; > + > + i2c@12CC0000 { > + status = "disabled"; > + }; > + > + i2c@12CD0000 { > + status = "disabled"; > + }; > + > + i2c@121D0000 { > + status = "disabled"; > + }; > + > + dwmmc_0: dwmmc0@12200000 { > + num-slots = <1>; > + supports-highspeed; > + broken-cd; > + fifo-depth = <0x80>; > + card-detect-delay = <200>; > + samsung,dw-mshc-ciu-div = <3>; > + samsung,dw-mshc-sdr-timing = <2 3>; > + samsung,dw-mshc-ddr-timing = <1 2>; > + > + slot@0 { > + reg = <0>; > + bus-width = <8>; > + gpios = <&gpc0 0 2 0 3>, <&gpc0 1 2 0 3>, > + <&gpc1 0 2 3 3>, <&gpc1 1 2 3 3>, > + <&gpc1 2 2 3 3>, <&gpc1 3 2 3 3>, > + <&gpc0 3 2 3 3>, <&gpc0 4 2 3 3>, > + <&gpc0 5 2 3 3>, <&gpc0 6 2 3 3>; > + }; > + }; > + > + dwmmc_1: dwmmc1@12210000 { > + status = "disabled"; > + }; > + > + dwmmc_2: dwmmc2@12220000 { > + num-slots = <1>; > + supports-highspeed; > + fifo-depth = <0x80>; > + card-detect-delay = <200>; > + samsung,dw-mshc-ciu-div = <3>; > + samsung,dw-mshc-sdr-timing = <2 3>; > + samsung,dw-mshc-ddr-timing = <1 2>; > + > + slot@0 { > + reg = <0>; > + bus-width = <4>; > + samsung,cd-pinmux-gpio = <&gpc3 2 2 3 3>; > + gpios = <&gpc3 0 2 0 3>, <&gpc3 1 2 0 3>, > + <&gpc3 3 2 3 3>, <&gpc3 4 2 3 3>, > + <&gpc3 5 2 3 3>, <&gpc3 6 2 3 3>, > + <&gpc4 3 3 3 3>, <&gpc4 3 3 3 3>, > + <&gpc4 5 3 3 3>, <&gpc4 6 3 3 3>; > + }; > + }; > + > + dwmmc_3: dwmmc3@12230000 { > + status = "disabled"; > + }; > + > + spi_0: spi@12d20000 { > + status = "disabled"; > + }; > + > + spi_1: spi@12d30000 { > + status = "disabled"; > + }; > + > + spi_2: spi@12d40000 { > + status = "disabled"; > + }; > +}; > -- > 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |