On Mon, Jan 21, 2013 at 06:25:18PM +0800, Chen Gang wrote: > > the buff size is 256, so need use vsnprintf instead of vsprintf. > > Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx> > --- > arch/arm/plat-samsung/pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c > index 1507028..8d07b45 100644 > --- a/arch/arm/plat-samsung/pm.c > +++ b/arch/arm/plat-samsung/pm.c > @@ -51,7 +51,7 @@ void s3c_pm_dbg(const char *fmt, ...) > char buff[256]; > > va_start(va, fmt); > - vsprintf(buff, fmt, va); > + vsnprintf(buff, 256, fmt, va); How about: vsnprintf(buff, sizeof(buff), fmt, va); It means we do not end up assuming the size of 'buff' and will be correct if the code is changed to declare 'buff' to be a different size. -- Ben Dooks, ben@xxxxxxxxx, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |