Hi, On Mon, Jan 21, 2013 at 12:15:10PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Mon, Jan 14, 2013 at 6:29 PM, Vivek Gautam <gautam.vivek@xxxxxxxxxxx> wrote: > > Changes from v2: > > - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating > > usb 2.0 phy controller's driver for Samsung's SoCs. > > - Moving the register definitions and strcuture definitions to > > common header file 'samsung-usbphy.h' to be used across > > usb 2.0 and usb 3.0 phy. > > - Keeping common exported function definitions in samsung-usbphy.c > > which can be used across usb 2.0 and usb 3.0 phy. > > - Writting separate driver file for Samsung's USB 3.0 phy controller. > > and making it dependent on USB_DWC3. > > > > Is the re-organization being done here fine as per requirements for > separate drivers for usb 2.0 type PHY and usb 3.0 type PHY ? should be fine ;-) If there is *truly generic* pieces, it makes sense to re-use - unless those "generic" parts are common driver churn (platform_driver definition, module_init(), module_exit(), etc). -- balbi
Attachment:
signature.asc
Description: Digital signature
