Re: [PATCH] ARM: dts: correct the dw-mshc timing properties as per binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Doug,

On Tue, Jan 8, 2013 at 12:34 AM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> Alim,
>
> On Mon, Jan 7, 2013 at 3:19 AM, Alim Akhtar <alim.akhtar@xxxxxxxxxxx> wrote:
> > As per the current exynos-dw-mshc bindings, dw-mshc-sdr-timing and
> > dw-mshc-ddr-timing properties are having only two cells, these properties
> > are wrongly set for exynos5250 based cros5250 and smdk5250 platfroms. This patch
> > corrects above timing propreties for above platfroms
>
> Thanks for catching this.  Given that this just removes a number from
> the dts file that isn't read by the code, I don't expect any
> functional change and I don't see any.
>
> I also double-checked usage and compared to the current Chrome OS
> tree.  The third number (that you removed) is already correctly
> specified in the dts as "samsung,dw-mshc-ciu-div".  :)

 Yes, no functional changes as the removed number is passed using
dw-mshc-ciu-div  property now as mentioned by you.
>
>
>
> > Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
>
> Tested-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Acked-by: Doug Anderson <dianders@xxxxxxxxxxxx>
Thanks!!!

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux