Vivek, On Wed, Dec 19, 2012 at 9:51 PM, Vivek Gautam <gautamvivek1987@xxxxxxxxx> wrote: > Hi Doug, > > > On Thu, Dec 20, 2012 at 3:18 AM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote: >> Vivek, >> >> Since you're changing the name, I would have expected to see a removal >> of the old enum type in this patch. I don't see it. After applying >> all of your patches I find that S5P_USB_PHY_HOST and >> S5P_USB_PHY_DEVICE are still defined and used. >> > > True that we should have removed the earlier defined enums, infact i > did the same > in patchset v4 for this series. But since in this patchset i separated > out drivers and > architecture part, i thought it would be easier to remove them in one > shot in a latter commit > which will actually touch upon all architecture related code > (mach-exynos/setup-usb-phy.c, > mach-s5pv210/setup-usb-phy.c, and include/plat/usb-phy.h) once this > approach is accepted. > >> $ git grep S5P_USB_PHY_HOST >> arch/arm/mach-exynos/setup-usb-phy.c: else if (type == S5P_USB_PHY_HOST) >> arch/arm/mach-exynos/setup-usb-phy.c: else if (type == S5P_USB_PHY_HOST) >> arch/arm/plat-samsung/include/plat/usb-phy.h: S5P_USB_PHY_HOST, >> >> I believe that those usages of the old enum should also be switched >> over and the old enum removed. >> > Sure, those enums need to be removed. > If you say i will submit a patch for the same. It would be nice to add it to the patch series in the next version. Thanks! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |