On Thu, Dec 6, 2012 at 3:46 PM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: > On Thu, 08 Nov 2012 12:24:24 +0530, Vivek Gautam <gautam.vivek@xxxxxxxxxxx> wrote: >> Adding EHCI device tree node for Exynos5250 along with >> the device base adress and gpio line for vbus. >> >> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx> >> Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx> >> --- >> .../devicetree/bindings/usb/exynos-usb.txt | 25 ++++++++++++++++++++ >> arch/arm/boot/dts/exynos5250-smdk5250.dts | 4 +++ >> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++ >> arch/arm/mach-exynos/include/mach/map.h | 1 + >> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 + >> 5 files changed, 38 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt >> >> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt >> new file mode 100644 >> index 0000000..833f5cf >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt >> @@ -0,0 +1,25 @@ >> +Samsung Exynos SoC USB controller >> + >> +The USB devices interface with USB controllers on Exynos SOCs. >> +The device node has following properties. >> + >> +EHCI >> +Required properties: >> + - compatible: should be "samsung,exynos-ehci" for USB 2.0 > > Ditto here. Please be specific in compatible strings. "samsung,exynos5250-ehci" > > Otherwise the binding looks fine to me. > Again here, the compatible string is added as per "drivers/usb/host/ehci-s5p.c", since same driver works across exynos. Please suggest do we need driver side change also to accomodate this ? > g. > > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss@xxxxxxxxxxxxxxxx > https://lists.ozlabs.org/listinfo/devicetree-discuss -- Thanks & Regards Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html