On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass <sjg@xxxxxxxxxxxx> wrote: > +Olof > > On Thu, Nov 29, 2012 at 8:34 AM, Mark Brown > <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: >> On Thu, Nov 29, 2012 at 10:35:35AM +0530, Naveen Krishna Chatradhi wrote: >> >>> The arbitrator is a general purpose function which uses two GPIOs to >>> communicate with another device to claim/release a bus. We use it to >>> arbitrate an i2c port between the AP and the EC. >> >> Should this not be layerd on top of the I2C controller rather than part >> of the controller driver? It doesn't seem terribly controller specific. > > It was originally done separately but I think it was felt that this > was overly complex. Olof can you please comment on this? it is indeed not controller specific per se, but we are unaware of any other platform/driver using it. So, it seemed reasonable to implement it in the driver as long as we have only one user; if another one comes along it's of course better to move it to the common i2c code. At least that was my opinion at the time. I could be convinced otherwise if someone else has strong opinions on the matter. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |