Alexander Varnin > > I also want to point, that irq resource in arch/arm/plat-samsung/devs.c > for s3c2410-spi driver on S3C2443 points to wrong IRQ (SPI0 instead of Sounds that you cannot use platform_device in plat-samsung/devs.c for SPI on S3C2443. Yes, could be... > SPI1). I've solved it with board specific code, but it is not most > correct way, i think. > Hmm, if provided platform_device is in plat-samsung/devs.c cannot support, we can do as you said temporarily but we know it's wrong way because the value depends on SoC not board. How about following? 8<-------------------------------- diff --git a/arch/arm/mach-s3c24xx/s3c2443.c b/arch/arm/mach-s3c24xx/s3c2443.c index 165b6a6..22eead3 100644 --- a/arch/arm/mach-s3c24xx/s3c2443.c +++ b/arch/arm/mach-s3c24xx/s3c2443.c @@ -82,6 +82,10 @@ int __init s3c2443_init(void) s3c_device_wdt.resource[1].start = IRQ_S3C2443_WDT; s3c_device_wdt.resource[1].end = IRQ_S3C2443_WDT; + /* change SPI IRQ number */ + s3c_device_spi0.resource[1].start = IRQ_SPI1; + s3c_device_spi0.resource[1].end = IRQ_SPI1; + return device_register(&s3c2443_dev); } 8<-------------------------------- K-Gene <kgene@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html