On 15 November 2012 12:34, Zhang Rui <rui.zhang@xxxxxxxxx> wrote: > On Thu, 2012-11-15 at 12:31 +0530, Amit Kachhap wrote: >> On 15 November 2012 12:09, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: >> > CPU_FREQ_TABLE depends on CPU_FREQ. Selecting CPU_FREQ_TABLE without checking >> > for dependencies gives the following compilation warnings: >> > warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC && UX500_SOC_DB8500 && >> > CPU_THERMAL && EXYNOS_THERMAL) selects CPU_FREQ_TABLE which has unmet >> > direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ) >> > >> > Cc: Amit Daniel Kachhap <amit.kachhap@xxxxxxxxxx> >> > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >> > --- >> > drivers/thermal/Kconfig | 3 +-- >> > 1 files changed, 1 insertions(+), 2 deletions(-) >> > >> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> > index 266c15e..6124c4b 100644 >> > --- a/drivers/thermal/Kconfig >> > +++ b/drivers/thermal/Kconfig >> > @@ -50,8 +50,7 @@ config RCAR_THERMAL >> > >> > config EXYNOS_THERMAL >> > tristate "Temperature sensor on Samsung EXYNOS" >> > - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && THERMAL >> > - select CPU_FREQ_TABLE >> Hi Sachin/Rui, >> >> "select CPU_FREQ_TABLE" should be there even if CONFIG_CPU_FREQ is >> enabled. Only some governors enable it. > > But CPU_THERMAL will select it, right? Ohh yes correct. Thanks > >> See drivers/cpufreq/Kconfig >> Also "depends THERMAL" should be there otherwise menuconfig >> parent/child relationship is broken. >> > this should be solved by my patch 1/2. :) > > thanks, > rui > >> Thanks, >> Amit Daniel >> >> > + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && CPU_THERMAL >> > help >> > If you say yes here you get support for TMU (Thermal Managment >> > Unit) on SAMSUNG EXYNOS series of SoC. >> > -- >> > 1.7.4.1 >> > > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |