Arnd Bergmann wrote: > [...] > This won't work. A driver can't "select" and "depend on" > another symbol at the same time. > Ooooops. You're right. I missed :-( > This is what I came up with earlier. > > Arnd > 8<---------------- > From a15cc6277a3a43c8b5c1dd90ca71732b2ffe2b18 Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann <arnd@xxxxxxxx> > Date: Wed, 10 Oct 2012 13:31:45 +0000 > Subject: [PATCH] pinctrl: samsung: don't allow enabling pinctrl-samsung > standalone > > The main samsung pinctrl module references the specific exynos4210 > pinctrl driver, which selects the main driver in Kconfig. > > Making the main driver a silent "bool" option avoid this potential > build error if CONFIG_PINCTRL_SAMSUNG=y && CONFIG_PINCTRL_EXYNOS4=n: > > drivers/built-in.o:(.rodata+0x4e4): undefined reference to > `exynos4210_pin_ctrl' > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Tomasz Figa <t.figa@xxxxxxxxxxx> > Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx> Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> Linus, can you pick this up in your pinctrl/fixes ree? Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index 7bf914d..9f54bd4 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -178,7 +178,7 @@ config PINCTRL_COH901 > ports of 8 GPIO pins each. > > config PINCTRL_SAMSUNG > - bool "Samsung pinctrl driver" > + bool > select PINMUX > select PINCONF > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |