On Monday 12 of November 2012 09:52:31 Russell King - ARM Linux wrote:
> On Thu, Oct 25, 2012 at 05:22:40PM +0200, Tomasz Figa wrote:
> > @@ -47,6 +48,8 @@ static inline void __iomem *cpu_boot_reg(int cpu)
> >
> > {
> >
> > void __iomem *boot_reg;
> >
> > + if (!call_firmware_op(cpu_boot_reg, cpu, &boot_reg))
> > + return boot_reg;
> >
> > boot_reg = cpu_boot_reg_base();
>
> That code makes no sense.
Why?
call_firmware_op returning 0 means a success, so boot_reg is filled with
proper boot register address, which should be used.
Otherwise (call_firmware_op returning an error) the legacy boot register
is used.
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
