On Thu, Oct 25, 2012 at 05:22:38PM +0200, Tomasz Figa wrote:
> +static int exynos_do_idle(void)
> +{
> + exynos_smc(SMC_CMD_SLEEP, 0, 0, 0);
> + return 0;
> +}
This looks fine as an API - it has a defined purpose.
> +
> +static int exynos_cpu_boot(int cpu)
> +{
> + exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0);
> + return 0;
> +}
Same for this (though, what _exactly_ is 'cpu', is it the physical CPU
number or the logical CPU number?)
> +
> +static int exynos_cpu_boot_reg(int cpu, void __iomem **ptr)
> +{
> + *ptr = S5P_VA_SYSRAM_NS + 0x1c + 4*cpu;
> + return 0;
> +}
This is really bad. What's it trying to do? What is the significance
of the 'ptr' returned? What if a platform doesn't have a boot register?
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
