On Tue, Nov 6, 2012 at 1:40 PM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Nov 05, 2012 at 05:21:03PM +0530, Shubhrajyoti Datta wrote: >> On Mon, Nov 5, 2012 at 2:03 PM, Mark Brown >> <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: >> > A small code saving and less error handling to worry about. > >> Looks good. > >> request irq could be devm_* also. Not an objection though. > > devm_ is a much worse idea for IRQs than for other resource types since > interrupts are delivered asynchronously. Using it safely requires that > we do the analysis required to make sure that the hardware is totally > idle and can't interrupt. hmm thats true. thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |