Hi Romain, On Wednesday 24 of October 2012 22:56:40 Romain Naour wrote: > Hi, > > This patch converts the s3c24xx timer driver to the > clocksource/clockevent API. I made some test on a mini2440 board and I > had to reduce timers frequency to 1MHz in order to produce a timer's > overflow every 64ms. Initial timer's frequency (8,45MHz) provide only > 7ms between each overflow. It is not enough. As timers were previously > used to produce an IRQ at 200Hz, some board (Osiris, Anubis board) use > an external 12MHz signal to clock the timers (tclk1). So, I changed > their configuration to select internal pclk clock instead, but I can't > test it. Also, I created a new file (s3c24xx_time.c) to avoid impacting > the s3c64xx. Kernel rev v3.7-rc1 > > Do you have any comments on this patch ? Generally looks fine, but I have some doubts: - Isn't 64ms still way too little for overflow period? Someone who is more into Linux time keeping should comment on this. - Much of the code is duplicated from s5p-time, maybe s5p-time could be made a generic samsung-time instead? It could be also used for S3C64xx. CC'ing Heiko and Sylwester, as they might find this patch interesting. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |