> -----Original Message----- > From: Olof Johansson [mailto:olof@xxxxxxxxx] > Sent: Thursday, October 25, 2012 2:15 AM > To: Chanho Park > Cc: kgene.kim@xxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux- > arm-kernel@xxxxxxxxxxxxxxxxxxx; linux@xxxxxxxxxxxxxxxx; ben-linux@xxxxxxxxx; > kyungmin.park@xxxxxxxxxxx; sachin.kamat@xxxxxxxxxx; > thomas.abraham@xxxxxxxxxx; will.deacon@xxxxxxx > Subject: Re: [PATCH v5 3/5] ARM: EXYNOS: Enable PMUs for exynos4 > > Hi, > > On Tue, Oct 23, 2012 at 10:34 PM, Chanho Park > <chanho61.park@xxxxxxxxxxx> wrote: > > This patch defines irq numbers of ARM performance monitoring unit for > exynos4. > > Firs of all, we need to fix IRQ_PMU correctly and to split pmu > > initialization of exynos from plat-samsung for easily defining it. > > > > The number of CPU cores and PMU irq numbers are vary according to soc > types. > > So, we need to identify each soc type using soc_is_xxx function and to > > define the pmu irqs dynamically. For example, the exynos4412 has 4 cpu > cores and pmus. > > I wonder if it's worth doing this complexity on the non-DT case for exynos4? > > I wish there was more focus on the Samsung platforms for getting the DT > support up to par with non-DT so you can avoid having to add new platform > devices like these in the first place. The DT support of exynos4 is under development. And many of exynos4 developers still use non-dt boot-up method. By this time arm-pmu of exynos did not work. IMO we should fix and support it for non-dt users. Thanks, Best regards, Chanho Park > > > Thanks, > > -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html