Hi! > > +#define S3C_PHYPWR (0x00) ... > > +#define S3C_PHYCLK (0x04) > > + > > +#define S3C_PHYCLK_MODE_SERIAL (1 << 6) > > +#define S3C_PHYCLK_EXT_OSC (1 << 5) > > +#define S3C_PHYCLK_COMMON_ON_N (1 << 4) > > +#define S3C_PHYCLK_ID_PULL (1 << 2) > > +#define S3C_PHYCLK_CLKSEL_MASK (0x3 << 0) > > +#define S3C_PHYCLK_CLKSEL_SHIFT (0) > > +#define S3C_PHYCLK_CLKSEL_48M (0x0 << 0) > > +#define S3C_PHYCLK_CLKSEL_12M (0x2 << 0) > > +#define S3C_PHYCLK_CLKSEL_24M (0x3 << 0) I believe these 0x 's should be removed. Ouch and << 0 is interesting, too, just remove it. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html