On 15-10-2012 15:58, Sylwester Nawrocki wrote:
Hi Heiko,
On 10/02/2012 02:43 PM, Heiko Stübner wrote:
Commit a5238e360b71 (spi: s3c64xx: move controller information into driver
data) introduced separate device names for the different subtypes of the
spi controller but forgot to set these in the relevant machines.
To fix this introduce a s3c64xx_spi_setname function and populate all
Samsung arches with the correct names. The function resides in a new
header, as the s3c64xx-spi.h contains driver platform data and should
therefore at some later point move out of the Samsung include dir.
Tested on a s3c2416-based machine.
Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
This patch looks good to me. I've tested it on Exynos4412 SoC based
board. And it fixes quite serious problem - broken SPI support on
a all Samsung machs (non-dt) except s3c64xx in mainline v3.6 kernel.
Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
Tested-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
(mach-exynos only)
José Miguel, can you confirm it solves the problem for you ?
The driver initialization problem is solved by this patch on my S3C2416 based
board. Nevertheless, I didn’t have the time yet to test an actual SPI device
connected to the bus.
BTW, I think the two debug messages at the end of the s3c64xx_spi_probe() routine
should be promoted from dev_dbg to dev_info in order to be shown on a normal
kernel boot.
Best regards,
José Gonçalves
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
