Hi Tomasz,
On Sat, Oct 13, 2012 at 3:34 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote:
> Hi Rahul,
>
> On Friday 12 of October 2012 00:27:42 Rahul Sharma wrote:
>> This patch adds support for device tree based discovery for exynos5
>> hdmi. Hdmi node is also renamed with "exynos5-hdmi".
>>
>> Signed-off-by: Rahul Sharma <rahul.sharma@xxxxxxxxxxx>
>> ---
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 4 ++++
>> arch/arm/boot/dts/exynos5250.dtsi | 7 +++++++
>> arch/arm/mach-exynos/include/mach/map.h | 1 +
>> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++
>> 4 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index a352df4..2a478ab
>> 100644
>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> @@ -166,4 +166,8 @@
>> spi_2: spi@12d40000 {
>> status = "disabled";
>> };
>> +
>> + hdmi {
>> + hpd-gpio = <&gpx3 7 0xf 1 3>;
>> + };
>> };
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi index f69e389..4e019b5 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -492,4 +492,11 @@
>> #gpio-cells = <4>;
>> };
>> };
>> +
>> + hdmi {
>
> hdmi@14530000
>
>> + compatible = "samsung,exynos5-hdmi";
>> + reg = <0x14530000 0x100000>;
>> + interrupts = <0 95 0>;
>> + version = "1.4";
>> + };
>
> Is it just me or there is something wrong with indentation of this
> bracket?
>
> Best regards,
> Tomasz Figa
>
My understanding was when there are multiple hardware instances of
same IP, addresses
are put along with the name like i2c, uart. But when only single hw IP
is present like
hdmi, mixer, watchdog, rtc etc address concatenation is optional.
Please correct me if
I am wrong. I will do the respective change.
in V2 patchset "version", "vp-support" properties are dropped and made
part of driver data
inside driver. I also added DT binding documentation for new nodes.
I had posted V2 yesterday but not visible on samsung-soc mailing list.
I will forward you the
patches.
regards,
Rahul Sharma
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
