On 10/12/2012 11:54 PM, Tomasz Figa wrote: >>> + if (of_get_property(dp_node, "interlaced", NULL)) >>> + dp_video_config->interlaced = 1; >> >> of_property_read_bool() could also be used here. > > Wouldn't it make the property mandatory? No, it wouldn't. of_property_read_bool() uses of_find_property() internally. It just returns true if property is found or false otherwise. Anyway, it appears of_get_property(..., NULL) pattern is commonly used for boolean properties. > I would just use of_find_property here, instead of of_get_property. > > Best regards, > Tomasz Figa -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |