On Mon, Oct 8, 2012 at 10:39 AM, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote: > This patch converts the pinctrl-exynos driver to parse wakeup interrupt > count and register offsets from device tree. It reduces the amount of > static platform-specific data and facilitates adding further SoC > variants to pinctrl-samsung driver. So these are: > + ret = of_property_read_u32(wkup_np, "samsung,weint-count", &val); > + ret = of_property_read_u32(wkup_np, "samsung,weint-con", &val); > + ret = of_property_read_u32(wkup_np, "samsung,weint-mask", &val); > + ret = of_property_read_u32(wkup_np, "samsung,weint-pend", &val); Are these all four register offsets? I don't think it's proper for the device tree to contain register offsets. Base address, "regs" property, yes. Individual registers, no. That just makes the code hard to read and compare to the datasheet. Or what are you aiming at here? Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |