Hi, On Fri, Sep 28, 2012 at 11:59 AM, Sangbeom Kim <sbkim73@xxxxxxxxxxx> wrote: > Hi! > On Thu, Sep 27, 2012 at 07:26 PM, Padmavathi Venna wrote: > >> Subject: [PATCH V2] ASoC: SAMSUNG: Add DT support for i2s >> >> Add support for device based discovery. >> >> Signed-off-by: Padmavathi Venna <padma.v@xxxxxxxxxxx> > > Please describe the difference between v1 and v2. There are no major comments in V1. I just addressed some of the comments given by kukjin kim(regarding clocks) ,Sachin(regarding I2S base addresses). As I deleted the variable which holds the names of the RCLK src clocks in the driver in the first patch set, this breaks the older platforms. So I reworked on older platforms and added I2S clkdev support and tested on s3c64xx series and deleted that variable from samsung-i2s structure. Added NULL in place of cdclk of sclk_audio0 src list because adding rate of that clk is a question to me because this is machine dependent and I am also not using this as parent clk. In my next version of patchset I will mention the difference clearly. > > Thanks, > Sangbeom. Thanks Padma > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html