On Thu, Sep 27, 2012 at 9:11 PM, Inderpal Singh <inderpal.singh@xxxxxxxxxx> wrote: > On 27 September 2012 15:18, Vinod Koul <vinod.koul@xxxxxxxxxxxxxxx> wrote: >> On Wed, 2012-09-26 at 12:11 +0530, Inderpal Singh wrote: >>> If we fail pl330_remove while some client is queued, the force unload >>> will fail and the >>> force unload will lose its purpose. >>> How about conditionally DMA_TERMINATE_ALL and free resources like >>> below ? >> Why would you want to remove the driver when it is doing something >> useful? You have to ensure driver is not doing anything. >> >> What is point here? >> > As mentioned by jassi, if the pl330 module is forced unloaded while > some client is queued, we have to manually do DMA_TERMINATE_ALL. > I meant that in the current situation. Not ideally. > If failing remove is a better option in case some client is queued, we > can do away with DMA_TERMINATE_ALL and free_chan_resources and simply > return a suitable error code from remove. > That was exactly what I suggested as an alternative. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |