RE: [PATCH V2 3/3] ARM: EXYNOS: Add drm-device node to the dtsi file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Leela Krishna Amudala wrote:
> 
> This patch adds platform drm-device node to the dtsi file
> 
> Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 6401c94..f0cc06d 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -495,4 +495,8 @@
>  		reg = <0x14400000 0x40000>;
>  		interrupts = <18 5>, <18 4>, <18 6>;
>  	};
> +
> +	drm-device {
> +		compatible = "samsung,exynos-drm-device";
> +	};
>  };
> --

Please check below comments from Thomas Abraham and I agree with his
opinion.

There cannot be a node that represents a virtual device. Device tree should
ideally describe the hardware but the above node does not represent a
hardware device. The creation of the platform device instance for the above
device should handled inside the kernel code.

Thanks.

K-Gene <kgene@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux