On Tuesday, September 11, 2012 6:20 PM Leela Krishna Amudala wrote
>
> Hello Jingoo Han,
>
> On Tue, Sep 11, 2012 at 5:52 AM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> > On Tuesday, September 11, 2012 5:11 AM Leela Krishna Amudala wrote
> >>
> >> This patch adds the bus clock for FIMD and changes the device name for lcd clock
> >> also sets mout_mpll_user as parent clock to fimd
> >>
> >> Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx>
> >> ---
> >> arch/arm/mach-exynos/clock-exynos5.c | 34 +++++++++++++++++++--------
> >> arch/arm/plat-samsung/include/plat/clock.h | 2 +
> >> 2 files changed, 26 insertions(+), 10 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c
> >> index 774533c..f1281cf 100644
> >> --- a/arch/arm/mach-exynos/clock-exynos5.c
> >> +++ b/arch/arm/mach-exynos/clock-exynos5.c
> >> @@ -891,6 +891,13 @@ static struct clk exynos5_clk_mdma1 = {
> >> .ctrlbit = (1 << 4),
> >> };
> >>
> >> +static struct clk exynos5_clk_fimd = {
> >> + .name = "fimd",
> >> + .devname = "exynos5-fb",
> >
> >
> > Replace 'exynos5-fb' with 'exynos5-fb.1', as exynos4 fimd uses exynos4-fb.0
> > as devname. Exynos5 can use fimd0 or fimd1. Also, Exynos5250 uses fimd1.
> >
> >
> Currently s3c-fb driver using "exynos5-fb" as device name, hence used
> the same name in the clock.
> This code is tested with both drm-fimd and s3c-fb fimd and it is
> working fine showing the display on LCD.
> If I change the device name in clock file then I have to change it in
> s3c-fb driver also.
> So I feel it is better to keep the name as "exynos5-fb" in clock file
> instead of changing in the driver.
No, there is no need to change the device name in s3c-fb driver.
Please refer to the patch that I sent 3 months ago.
http://www.mail-archive.com/linux-samsung-soc@xxxxxxxxxxxxxxx/msg11002.html
Now, Exynos5250 has only 1 FIMD IP; however, other Exynos5 SoCs
have 2 FIMD IPs. These SoCs have two different clock paths for
2 FIMD IPs. Therefore, we need to consider it.
>
> Thanks,
> Leela Krishna Amudala.
>
> >> + .enable = exynos5_clk_ip_disp1_ctrl,
> >> + .ctrlbit = (1 << 0),
> >> +};
> >> +
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
