Hi Thomas,
Thanks for reviewing the patch.
On Friday 31 of August 2012 09:18:26 Thomas Abraham wrote:
> A similar patch was submitted by Dongjin Kim
> <dongjin.kim@xxxxxxxxxxxxxxxxxxx> as well.
> [PATCH v2] arm/dts: exynos4: Add DTS files derived from common Exynos4
OK, I haven't noticed it.
> > + gic:interrupt-controller@10490000 {
> > + compatible = "arm,cortex-a9-gic";
> > + #interrupt-cells = <3>;
> > + interrupt-controller;
> > + cpu-offset = <0x8000>;
>
> The value of cpu-offset is different for Exynos4210 and Exynos4412
> (not sure if it is different on Exynos4212 as well). Since
> exynos4.dtsi will be included in the other Exynos4 specific dtsi
> files, cpu-offset property can be removed from here and included in
> SoC specific dtsi files.
OK.
> > + combiner:interrupt-controller@10440000 {
> > + compatible = "samsung,exynos4210-combiner";
> > + #interrupt-cells = <2>;
> > + interrupt-controller;
> > + reg = <0x10440000 0x1000>;
> > + interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>,
> > + <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>,
> > + <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>,
> > + <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>;
> > + };
>
> Similarly, the number of interrupts generated by the combiner is also
> specific to the Exynos4 SoC. So the interrupts property could also be
> moved into SoC specific dtsi files.
OK.
> > + gpio-controllers {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + gpio-controller;
> > + ranges;
>
> Should we just retain the gpio nodes in exynos4210.dtsi file itself
> for now. If we manage to get the pinctrl driver support for exynos4210
> and exynos4412 merged, these gpio nodes would anyway be removed. And
> since there are differences in gpio banks in Exynos4 SoC's, maybe we
> could just leave these in exynos4210.dtsi file for now.
Yes, might be a good idea indeed.
> While we are at it, should we mark the nodes in exynos4.dtsi and
> exynos4210.dtsi as "disabled". The board dts files will have to
> explicitly "enable" those nodes which it uses.
Definitely. Actually I was going to submit patches for it a bit later.
I have them ready now and I'm going to send them today, along with
corrected version of this patch.
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
