On 8/29/12, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > On 08/28/12 03:06, Tomasz Figa wrote: >> The GPEx gpios are specific to Exynos4210 and do not exist on Exynos4x12. >> Redefine them to use the exact SoC name. >> >> Based on "ARM: EXYYNOS: Use EXYNOS4210_GPEx instead of EXYNOS4_GPEx" by >> Joonyoung Shim, see: >> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-May/100738.html >> >> Signed-off-by: Tomasz Figa<t.figa@xxxxxxxxxxx> >> --- >> arch/arm/mach-exynos/include/mach/gpio.h | 32 >> +++++++++++++++--------------- >> arch/arm/mach-exynos/mach-nuri.c | 16 +++++++-------- >> arch/arm/mach-exynos/mach-origen.c | 6 +++--- >> arch/arm/mach-exynos/mach-trats.c | 4 ++-- >> arch/arm/mach-exynos/mach-universal_c210.c | 32 >> +++++++++++++++--------------- >> arch/arm/mach-exynos/setup-fimc.c | 4 ++-- >> drivers/gpio/gpio-samsung.c | 20 +++++++++---------- >> 7 files changed, 57 insertions(+), 57 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/include/mach/gpio.h >> b/arch/arm/mach-exynos/include/mach/gpio.h >> index eb24f1e..21c9bf1 100644 >> --- a/arch/arm/mach-exynos/include/mach/gpio.h >> +++ b/arch/arm/mach-exynos/include/mach/gpio.h >> @@ -26,11 +26,11 @@ >> #define EXYNOS4_GPIO_C1_NR (5) >> #define EXYNOS4_GPIO_D0_NR (4) >> #define EXYNOS4_GPIO_D1_NR (4) >> -#define EXYNOS4_GPIO_E0_NR (5) >> -#define EXYNOS4_GPIO_E1_NR (8) >> -#define EXYNOS4_GPIO_E2_NR (6) >> -#define EXYNOS4_GPIO_E3_NR (8) >> -#define EXYNOS4_GPIO_E4_NR (8) >> +#define EXYNOS4210_GPIO_E0_NR (5) >> +#define EXYNOS4210_GPIO_E1_NR (8) >> +#define EXYNOS4210_GPIO_E2_NR (6) >> +#define EXYNOS4210_GPIO_E3_NR (8) >> +#define EXYNOS4210_GPIO_E4_NR (8) > > Please see my comments on Joonyoung Shim's previous patch... > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-May/101522.html It's perference issue. some person like this style. others doesn't. Moreever vender, System LSI, provided codes have whole different style. It lists up whole gpios for each SoCs. EXYNOS4210_{A0, .... Z} EXYNOS4412_{A0, .... V4} EXYNOS5250_{A0, .... Z} anyway, just remain it as broken, and try to use pinctl as Thomas mentioned. Thank you, Kyungmin Park > > [...] > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |