Julia Lawall wrote: > > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > Initialize return variable before exiting on an error path. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> (Cc'ed Mark Brown who is handling spi for a moment) > --- > Perhaps -EINVAL is not the right value in this case. > Well, if (pin_cs < 0) is true, it is really invalid value. So I think, it makes sense :-) Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > drivers/spi/spi-s3c24xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c > index 8ee7d79..a2a080b 100644 > --- a/drivers/spi/spi-s3c24xx.c > +++ b/drivers/spi/spi-s3c24xx.c > @@ -611,6 +611,7 @@ static int __devinit s3c24xx_spi_probe(struct > platform_device *pdev) > if (!pdata->set_cs) { > if (pdata->pin_cs < 0) { > dev_err(&pdev->dev, "No chipselect pin\n"); > + err = -EINVAL; > goto err_register; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |