On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham <thomas.abraham@xxxxxxxxxx> wrote: > Add information about the Exynos4210 pin banks and driver data which is > used by the Samsung pinctrl driver. In addition to this, the support for > external gpio and wakeup interrupt support is included and hooked up with > the Samsung pinctrl driver. OK... > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > +config PINCTRL_EXYNOS4 > + bool "Pinctrl driver data for Exynos4 SoC" > + depends on ARCH_EXYNOS4 && OF Since you depend on PINCTRL_SAMSUNG which depends on OF you don't need to depend on OF here. > + depends on PINCTRL_SAMSUNG > + select PINMUX > + select PINCONF So as noted in the main driver, let PINCTRL_SAMSUNG select PINMUX and PINCONF and you need only select PINCTRL_SAMSUNG here. > diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c (...) > +#include <linux/interrupt.h> > +#include <linux/irqdomain.h> > +#include <linux/irq.h> > +#include <linux/of_irq.h> Do you need these includes? Didn't you put them all in "pinctrl-samsung.h"? Overall this looks good and straight-forward, but I cannot figure out how the samsung_pinctrl_soc_data is passed to the main driver, it seems to be through some DT node but I cannot figure this out. Can you explain this? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |