On Mon, Aug 13, 2012 at 08:21:14AM +0100, shiraz hashim wrote: > On Wed, Nov 17, 2010 at 2:37 PM, Catalin Marinas > <catalin.marinas@xxxxxxx> wrote: > > > > On Wed, 2010-11-17 at 06:55 +0000, Kukjin Kim wrote: > > > --- a/arch/arm/mach-s5pv310/cpu.c > > > +++ b/arch/arm/mach-s5pv310/cpu.c > > > @@ -168,7 +168,7 @@ static int __init s5pv310_l2x0_cache_init(void) > > > __raw_writel(L2X0_DYNAMIC_CLK_GATING_EN | L2X0_STNDBY_MODE_EN, > > > S5P_VA_L2CC + L2X0_POWER_CTRL); > > > > > > - l2x0_init(S5P_VA_L2CC, 0x7C070001, 0xC200ffff); > > > + l2x0_init(S5P_VA_L2CC, 0x7C470001, 0xC200ffff); > > > > The patch is fine. > > > > But I think we should also set this bit in the cache-l2x0.c file if > > PL310. That's such a fundamental issue and it's easy to miss in the > > platform code. > > Sorry for reviving this old patch but any reasons why it didn't > go to the cache-l2x0.c directly (for PL310). The cache-l2x0.c patch has been around for a while: http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6529/1 It may no longer apply cleanly but I haven't revived it since it wasn't accepted at the time. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html