Sachin Kamat wrote: > > Hi Mark, > > On 8 August 2012 16:39, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > wrote: > > On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote: > >> Fixes the following build error: > >> In file included from arch/arm/mach-exynos/include/mach/dma.h:24:0, > >> from arch/arm/plat-samsung/include/plat/dma-ops.h:17, > >> from arch/arm/plat-samsung/include/plat/dma.h:128, > >> from sound/soc/samsung/pcm.c:23: > >> arch/arm/plat-samsung/include/plat/dma-pl330.h:106:8: > >> error: redefinition of 'struct s3c2410_dma_client' > >> arch/arm/plat-samsung/include/plat/dma.h:40:8: note: originally defined > here > >> make[3]: *** [sound/soc/samsung/pcm.o] Error 1 > > > > Shouldn't this be being fixed in the headers? It looks like they > > reference and disagree with each other on Exynos (my primary development > > platform is S3C6410 based so I'd notice if it was a generic Samsung > > issue. > > > > Pasting the error message isn't really that useful unless the fix is > > obvious, it's better to explain in words what's wrong. > > I had sent the initial patch trying to fix this in the headers and it > worked for exynos4 config. However Kukjin pointed out that the patch > created similar errors with 2410 and 6400 configs. Fixing it further > in the headers did not look quite straight forward as there are many > headers trying to include one another. Hence I felt it is better > handled in the current way. I understand i should have added this > information in the commit message. Below is the link for your > reference that provides the complete discussion. > > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/11274 > > Please let me know your opinion about this. > > I also agree with Mark's opinion and current Sachin's approach cannot avoid whole similar build error. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |