On Wed, Aug 1, 2012 at 8:08 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Thursday 26 July 2012, Vinayak Holikatti wrote: > >> -static void ufshcd_remove(struct pci_dev *pdev) >> +void ufshcd_remove(struct ufs_hba *hba) >> { >> - struct ufs_hba *hba = pci_get_drvdata(pdev); >> - >> /* disable interrupts */ >> ufshcd_int_config(hba, UFSHCD_INT_DISABLE); >> - free_irq(pdev->irq, hba); >> >> ufshcd_hba_stop(hba); >> ufshcd_hba_free(hba); >> >> scsi_remove_host(hba->host); >> scsi_host_put(hba->host); >> +} >> +EXPORT_SYMBOL(ufshcd_remove); > > For driver internal symbols, you should always use "EXPORT_SYMBOL_GPL" > here. Ok, will use EXPORT_SYMBOL_GPL > > Arnd > -- Regards, Vinayak Holikatti -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html