Shaik Ameer Basha wrote:
>
> This patch adds,
> - 4 Gscaler devices to the DT device list
> - Gscaler specific entries to the machine file
> - binding documentation for Gscaler entries
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx>
> Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx>
> Signed-off-by: Shaik Ameer Basha <shaik.ameer@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/media/exynos5-gsc.txt | 32
> ++++++++++++++++++++
> arch/arm/boot/dts/exynos5250.dtsi | 28
+++++++++++++++++
> arch/arm/mach-exynos/include/mach/map.h | 3 ++
> arch/arm/mach-exynos/mach-exynos5-dt.c | 8 +++++
> 4 files changed, 71 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/exynos5-
> gsc.txt
>
> diff --git a/Documentation/devicetree/bindings/media/exynos5-gsc.txt
> b/Documentation/devicetree/bindings/media/exynos5-gsc.txt
> new file mode 100644
> index 0000000..1cb4ea0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/exynos5-gsc.txt
> @@ -0,0 +1,32 @@
> +* Samsung Exynos5 Gscaler device
> +
> +Gscaler is used for scaling and color space conversion on EXYNOS5 SoCs.
> +
> +Required properties:
> +- compatible: should be "samsung,exynos5250-gsc"
IMO, should be "samsung,exynos5-gsc" because upcoming EXYNOS5 SoCs can use
same gscaler driver.
> +- reg: should contain Gscaler physical address location and length.
> +- interrupts: should contain Gscaler interrupt number
> +
> +Example:
> +
> +gsc_0: gsc@0x13e00000 {
> + compatible = "samsung,exynos5250-gsc";
+ compatible = "samsung,exynos5-gsc";
> + reg = <0x13e00000 0x1000>;
> + interrupts = <0 85 0>;
> +};
> +
[...]
> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-
> exynos/include/mach/map.h
> index c72b675..217e470 100644
> --- a/arch/arm/mach-exynos/include/mach/map.h
> +++ b/arch/arm/mach-exynos/include/mach/map.h
> @@ -121,6 +121,9 @@
> #define EXYNOS4_PA_SYSMMU_MFC_L 0x13620000
> #define EXYNOS4_PA_SYSMMU_MFC_R 0x13630000
>
> +/* x = 0...3 */
> +#define EXYNOS5_PA_GSC(x) (0x13e00000 + ((x) * 0x10000))
I think, separated definitions would be nice because the number of channel
can be changed on other upcoming EXYNOS5 SoCs.
+#define EXYNOS5_PA_GSC0 0x13E00000
+#define EXYNOS5_PA_GSC1 0x13E10000
+#define EXYNOS5_PA_GSC2 0x13E20000
+#define EXYNOS5_PA_GSC3 0x13E30000
[...]
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
