Hi Sachin,
On 07/16/2012 08:42 AM, Sachin Kamat wrote:
Pixcir touchscreen device support is added to SMDK4X12 boards.
Signed-off-by: Sachin Kamat<sachin.kamat@xxxxxxxxxx>
---
This patch is based on Kukjin Kim's latest for-next branch.
Changes since v1:
Incorporated Kukjin's review comments
-reduced mdelay
-removed a unnecessary gpio
---
arch/arm/mach-exynos/mach-smdk4x12.c | 31 ++++++++++++++++++++++++++++++-
1 files changed, 30 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-exynos/mach-smdk4x12.c b/arch/arm/mach-exynos/mach-smdk4x12.c
index 2623f3b..b3207ea 100644
--- a/arch/arm/mach-exynos/mach-smdk4x12.c
+++ b/arch/arm/mach-exynos/mach-smdk4x12.c
@@ -9,9 +9,11 @@
* published by the Free Software Foundation.
*/
+#include<linux/delay.h>
#include<linux/gpio.h>
#include<linux/i2c.h>
#include<linux/input.h>
+#include<linux/input/pixcir_ts.h>
#include<linux/io.h>
#include<linux/lcd.h>
#include<linux/mfd/max8997.h>
@@ -207,8 +209,33 @@ static struct i2c_board_info smdk4x12_i2c_devs3[] __initdata = {
/* nothing here yet */
};
+static void smdk4x12_ts_gpio_setup(void)
+{
+ int gpio_reset = EXYNOS4_GPM3(4);
I don't seem to find this GPIO defined in Kgene's for-next tree.
Is there already GPIO support for Exynos4x12 SoC's merged in someone's
tree ? I thought it's not completed yet.
+
+ gpio_request_one(gpio_reset, GPIOF_OUT_INIT_LOW, "TOUCH RESET");
+ mdelay(2);
Any reason to use mdelay, rather than msleep/usleep_range ?
+ gpio_direction_output(gpio_reset, 1);
Probably better to make it:
gpio_set_value(gpio_reset, 1);
since the GPIO's direction is already set in gpio_request_one().
+ mdelay(30);
msleep(30);
--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
