Sachin Kamat wrote:
>
> Pixcir touchscreen device support is added to SMDK4X12 boards.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> ---
> arch/arm/mach-exynos/mach-smdk4x12.c | 32
> +++++++++++++++++++++++++++++++-
> 1 files changed, 31 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/mach-smdk4x12.c b/arch/arm/mach-
> exynos/mach-smdk4x12.c
> index fe772d8..0af6088 100644
> --- a/arch/arm/mach-exynos/mach-smdk4x12.c
> +++ b/arch/arm/mach-exynos/mach-smdk4x12.c
> @@ -9,10 +9,12 @@
> * published by the Free Software Foundation.
> */
>
> +#include <linux/delay.h>
> #include <linux/gpio.h>
> #include <linux/i2c.h>
> #include <linux/input.h>
> #include <linux/io.h>
> +#include <linux/input/pixcir_ts.h>
> #include <linux/mfd/max8997.h>
> #include <linux/mmc/host.h>
> #include <linux/platform_device.h>
> @@ -203,8 +205,34 @@ static struct i2c_board_info smdk4x12_i2c_devs3[]
> __initdata = {
> /* nothing here yet */
> };
>
> +static void smdk4x12_ts_gpio_setup(void)
> +{
> + int gpio_reset = EXYNOS4_GPM3(4);
> +
> + gpio_request_one(gpio_reset, GPIOF_OUT_INIT_LOW, "TOUCH RESET");
> + mdelay(20);
> + gpio_direction_output(gpio_reset, 1);
Do you want to set the gpio_reset value from 0 to 1 with 20m delays? Why?
> + mdelay(30);
> + s3c_gpio_setpull(EXYNOS4_GPX2(6), S3C_GPIO_PULL_NONE);
Hmm...don't we need gpio_reqeust()? and what's the gpx2(6)?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
