Sachin Kamat wrote:
>
> G2D clock registers are different in Exynos4210 and Exynos4X12 SoCs.
> Hence moving the SoC specific G2D clock entries from common clock file
> (clock-exynos4.c) to Exynos4210 specific clock file (clock-exynos4210.c).
>
Yeah, I agree but there are small comments.
[snip]
> +static struct clksrc_clk exynos4_clk_mout_g2d0 = {
In this case, 'exynos4210_clk_mout_g2d0' is clearer, it is static though.
> + .clk = {
> + .name = "mout_g2d0",
> + },
> + .sources = &exynos4_clkset_mout_g2d0,
> + .reg_src = { .reg = EXYNOS4_CLKSRC_IMAGE, .shift = 0, .size = 1 },
> +};
> +
> +static struct clksrc_clk exynos4_clk_mout_g2d1 = {
Same as above, exynos4210_clk_mout_g2d1.
> + .clk = {
> + .name = "mout_g2d1",
> + },
> + .sources = &exynos4_clkset_mout_g2d1,
> + .reg_src = { .reg = EXYNOS4_CLKSRC_IMAGE, .shift = 4, .size = 1 },
> +};
> +
> +static struct clk *exynos4_clkset_mout_g2d_list[] = {
Same, exynos4210_clkset_mout_g2d_list[]
> + [0] = &exynos4_clk_mout_g2d0.clk,
exynos4210_clk_mout_g2d0.clk
> + [1] = &exynos4_clk_mout_g2d1.clk,
exynos4210_clk_mout_g2d1.clk
> +};
> +
> +static struct clksrc_sources exynos4_clkset_mout_g2d = {
Same, exynos4210_clkset_mout_g2d
> + .sources = exynos4_clkset_mout_g2d_list,
exynos4210_clkset_mout_g2d_list
> + .nr_sources = ARRAY_SIZE(exynos4_clkset_mout_g2d_list),
exynos4210_clkset_mout_g2d_list
> +};
> +
> static int exynos4_clksrc_mask_lcd1_ctrl(struct clk *clk, int enable)
> {
> return s5p_gatectrl(EXYNOS4210_CLKSRC_MASK_LCD1, clk, enable);
> @@ -74,6 +100,13 @@ static struct clksrc_clk clksrcs[] = {
> .sources = &exynos4_clkset_group,
> .reg_src = { .reg = EXYNOS4210_CLKSRC_LCD1, .shift =
> 0, .size = 4 },
> .reg_div = { .reg = EXYNOS4210_CLKDIV_LCD1, .shift =
> 0, .size = 4 },
> + }, {
> + .clk = {
> + .name = "sclk_fimg2d",
> + },
> + .sources = &exynos4_clkset_mout_g2d,
exynos4210_clkset_mout_g2d
[snip]
Could you please re-submit this after re-working on top of my
next/devel-samsung.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
