On 10 July 2012 22:27, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote: > >> In non-dt case, the platform code supplying the gpio number (slave >> select line) is responsible for requesting the gpio during the >> machine_init call. So the gpio request is not called in the driver for >> that gpio. In dt case, the 6th patch adds dt support and that patch >> includes a gpio request call. Hence, this looks okay to me. Please >> suggest if you still feel that there are changes required. > > That's not really particularly sensible given that the changes remove > the option to use anything except GPIOs, the GPIO request should be done > unconditionally in the driver now. Yes, that is right. I will add the gpio request in the driver and resubmit the patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |