Re: [PATCH 1/4] [SCSI] ufs: Separate PCI glue driver for ufshcd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 02 July 2012, Vinayak Holikatti wrote:
> 
> This patch separates PCI and core UFS host controller driver.
> In the current implementation PCI specific code is with ufshcd.c.
> To provide way for adding multiple bus glue driver, this patch
> separates PCI layer from ufshcd core. Now ufshcd compiles as separate
> module and ufshcd-pci as separate module.
> 
> Signed-off-by: Vinayak Holikatti <vinholikatti@xxxxxxxxx>
> Signed-off-by: Santosh Yaraganavi <santoshsy@xxxxxxxxx>

Hi Vinayak,

This patch looks good at first sight, but it's a little hard to
review in the form that you are posting.

I would recommend that you split this patch into two separate
changesets, where you do all the changes to existing code in the
first patch, and only move but don't change code in the second one
that creates the new file.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux