RE: [PATCH] ARM: SAMSUNG: Should check for IS_ERR(clk) instead of NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



jhbird.choi@xxxxxxxxx wrote:
> 
> From: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
> 
> On the error condition clk_get() returns ERR_PTR().
> 
> Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
> ---
>  .../arm/plat-samsung/include/plat/watchdog-reset.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/include/plat/watchdog-reset.h
> b/arch/arm/plat-samsung/include/plat/watchdog-reset.h
> index f19aff1..bc4db9b 100644
> --- a/arch/arm/plat-samsung/include/plat/watchdog-reset.h
> +++ b/arch/arm/plat-samsung/include/plat/watchdog-reset.h
> @@ -25,7 +25,7 @@ static inline void arch_wdt_reset(void)
> 
>  	__raw_writel(0, S3C2410_WTCON);	  /* disable watchdog, to be safe
> */
> 
> -	if (s3c2410_wdtclk)
> +	if (!IS_ERR(s3c2410_wdtclk))
>  		clk_enable(s3c2410_wdtclk);
> 
>  	/* put initial values into count and data */
> --
> 1.7.0.4

Applied, thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux