On 19/06/2012, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> Sachin Kamat wrote:
>>
>> Adds clock setting entries for Exynos4212 and Exynos4412 platforms.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>> ---
>> arch/arm/mach-exynos/include/mach/regs-usb-phy.h | 20 ++++++--
>> arch/arm/mach-exynos/setup-usb-phy.c | 55
> ++++++++++++++++-----
>> arch/arm/plat-samsung/include/plat/cpu.h | 4 ++
>> 3 files changed, 61 insertions(+), 18 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/include/mach/regs-usb-phy.h
>> b/arch/arm/mach-exynos/include/mach/regs-usb-phy.h
>> index c337cf3..0727773 100644
>> --- a/arch/arm/mach-exynos/include/mach/regs-usb-phy.h
>> +++ b/arch/arm/mach-exynos/include/mach/regs-usb-phy.h
>> @@ -35,11 +35,21 @@
>> #define PHY1_COMMON_ON_N (1 << 7)
>> #define PHY0_COMMON_ON_N (1 << 4)
>> #define PHY0_ID_PULLUP (1 << 2)
>> -#define CLKSEL_MASK (0x3 << 0)
>> -#define CLKSEL_SHIFT (0)
>> -#define CLKSEL_48M (0x0 << 0)
>> -#define CLKSEL_12M (0x2 << 0)
>> -#define CLKSEL_24M (0x3 << 0)
>> +
>> +#define EXYNOS4_CLKSEL_SHIFT (0)
>> +
>> +#define EXYNOS4210_CLKSEL_MASK (0x3 << 0)
>> +#define EXYNOS4210_CLKSEL_48M (0x0 << 0)
>> +#define EXYNOS4210_CLKSEL_12M (0x2 << 0)
>> +#define EXYNOS4210_CLKSEL_24M (0x3 << 0)
>> +
>> +#define EXYNOS4X12_CLKSEL_MASK (0x7 << 0)
>> +#define EXYNOS4X12_CLKSEL_9600K (0x0 << 0)
>> +#define EXYNOS4X12_CLKSEL_10M (0x1 << 0)
>> +#define EXYNOS4X12_CLKSEL_12M (0x2 << 0)
>> +#define EXYNOS4X12_CLKSEL_19200K (0x3 << 0)
>> +#define EXYNOS4X12_CLKSEL_20M (0x4 << 0)
>> +#define EXYNOS4X12_CLKSEL_24M (0x5 << 0)
>>
>> #define EXYNOS4_RSTCON EXYNOS4_HSOTG_PHYREG(0x08)
>> #define HOST_LINK_PORT_SWRST_MASK (0xf << 6)
>> diff --git a/arch/arm/mach-exynos/setup-usb-phy.c b/arch/arm/mach-
>> exynos/setup-usb-phy.c
>> index 1af0a7f..8f90ce0 100644
>> --- a/arch/arm/mach-exynos/setup-usb-phy.c
>> +++ b/arch/arm/mach-exynos/setup-usb-phy.c
>> @@ -31,22 +31,51 @@ static void exynos4210_usb_phy_clkset(struct
>> platform_device *pdev)
>> struct clk *xusbxti_clk;
>> u32 phyclk;
>>
>> - /* set clock frequency for PLL */
>> - phyclk = readl(EXYNOS4_PHYCLK) & ~CLKSEL_MASK;
>>
>> xusbxti_clk = clk_get(&pdev->dev, "xusbxti");
>> if (xusbxti_clk && !IS_ERR(xusbxti_clk)) {
>> - switch (clk_get_rate(xusbxti_clk)) {
>> - case 12 * MHZ:
>> - phyclk |= CLKSEL_12M;
>> - break;
>> - case 24 * MHZ:
>> - phyclk |= CLKSEL_24M;
>> - break;
>> - default:
>> - case 48 * MHZ:
>> - /* default reference clock */
>> - break;
>> + if (soc_is_exynos4210()) {
>> + /* set clock frequency for PLL */
>> + phyclk = readl(EXYNOS4_PHYCLK) &
>> ~EXYNOS4210_CLKSEL_MASK;
>> +
>> + switch (clk_get_rate(xusbxti_clk)) {
>> + case 12 * MHZ:
>> + phyclk |= EXYNOS4210_CLKSEL_12M;
>> + break;
>> + case 24 * MHZ:
>> + phyclk |= EXYNOS4210_CLKSEL_24M;
>> + break;
>> + default:
>> + case 48 * MHZ:
>> + /* default reference clock */
>
> Shouldn't this 24Mhz? Because the clk_xusbxti.rate is 24Mhz in most board
> file?
Yes, you are right. I will modify the same.
>
>> + break;
>> + }
>> + } else if (soc_is_exynos4212() || soc_is_exynos4412()) {
>> + /* set clock frequency for PLL */
>> + phyclk = readl(EXYNOS4_PHYCLK) &
>> ~EXYNOS4X12_CLKSEL_MASK;
>> +
>> + switch (clk_get_rate(xusbxti_clk)) {
>> + case 9600 * KHZ:
>> + phyclk |= EXYNOS4X12_CLKSEL_9600K;
>> + break;
>> + case 10 * MHZ:
>> + phyclk |= EXYNOS4X12_CLKSEL_10M;
>> + break;
>> + case 12 * MHZ:
>> + phyclk |= EXYNOS4X12_CLKSEL_12M;
>> + break;
>> + case 19200 * KHZ:
>> + phyclk |= EXYNOS4X12_CLKSEL_19200K;
>> + break;
>> + case 20 * MHZ:
>> + phyclk |= EXYNOS4X12_CLKSEL_20M;
>> + break;
>
> Please list in order of the value?
I think they are already in increasing values in MHz (9.6, 10, 12,
19.2, 20 and 24).
Please let me know if this is what you meant.
>
>
>> + default:
>> + case 24 * MHZ:
>> + /* default reference clock */
>> + phyclk |= EXYNOS4X12_CLKSEL_24M;
>> + break;
>> + }
>> }
>> clk_put(xusbxti_clk);
>> }
>> diff --git a/arch/arm/plat-samsung/include/plat/cpu.h b/arch/arm/plat-
>> samsung/include/plat/cpu.h
>> index 787ceac..6a6ff7e 100644
>> --- a/arch/arm/plat-samsung/include/plat/cpu.h
>> +++ b/arch/arm/plat-samsung/include/plat/cpu.h
>> @@ -132,6 +132,10 @@ IS_SAMSUNG_CPU(exynos5250, EXYNOS5250_SOC_ID,
>> EXYNOS5_SOC_MASK)
>>
>> #define IODESC_ENT(x) { (unsigned long)S3C24XX_VA_##x,
>> __phys_to_pfn(S3C24XX_PA_##x), S3C24XX_SZ_##x, MT_DEVICE }
>>
>> +#ifndef KHZ
>> +#define KHZ (1000)
>> +#endif
>> +
>> #ifndef MHZ
>> #define MHZ (1000*1000)
>> #endif
>> --
>> 1.7.4.1
>
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
