I agree with you, looks like a bug that got introduced with SDIO support.
acked-by Shashidhar Hiremath <shashidharh@xxxxxxxxxxxxxxx>
On Mon, May 14, 2012 at 2:08 PM, Kyoungil Kim <ki0351.kim@xxxxxxxxxxx> wrote:
> The sdio interrupt mask bits are arranged in [31:16].
> (1 << SDMMC_INT_SDIO(slot->id))) does 16 bits left shift twice.
> So this patch changes to do 16 bits left shift only one time.
>
> Signed-off-by: Kyoungil Kim <ki0351.kim@xxxxxxxxxxx>
> ---
> drivers/mmc/host/dw_mmc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 1532357..9bbf45f 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -857,10 +857,10 @@ static void dw_mci_enable_sdio_irq(struct mmc_host *mmc, int enb)
> int_mask = mci_readl(host, INTMASK);
> if (enb) {
> mci_writel(host, INTMASK,
> - (int_mask | (1 << SDMMC_INT_SDIO(slot->id))));
> + (int_mask | SDMMC_INT_SDIO(slot->id)));
> } else {
> mci_writel(host, INTMASK,
> - (int_mask & ~(1 << SDMMC_INT_SDIO(slot->id))));
> + (int_mask & ~SDMMC_INT_SDIO(slot->id)));
> }
> }
>
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
cheers,
Shashidhar Hiremath
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
