On Wed, May 09, 2012 at 01:50:28PM +0100, Sangwook Lee wrote: > struct generic_pm_domain already has a field for name. Use that field > instead of creating another field in struct exynos_pm_domain Argh. No. > @@ -99,7 +98,7 @@ static __init int exynos_pm_dt_parse_domains(void) > > if (of_get_property(np, "samsung,exynos4210-pd-off", NULL)) > pd->is_off = true; > - pd->name = np->name; > + pd->pd.name = (char *)np->name; Why this cast? Why can't pd->pd.name be correctly typed in the first place? I assume this is because np->name is const. Never EVER cast away const. It's wrong to do so. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |