[PATCH] ARM: SAMSUNG: Fix the value of tcnt and tcmp for PWM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



According to PWM hardware spec, the actual period which
has been calculated by period and input clock is same
with (tcnt + 1), so need to down count for tcnt register.
And current PWM HW checks the compare register after
tcmp++ internally in hardware.

Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
---
 arch/arm/plat-samsung/pwm.c |   23 +++++++++++++++++++----
 1 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/arch/arm/plat-samsung/pwm.c b/arch/arm/plat-samsung/pwm.c
index c559d84..88fdb1c 100644
--- a/arch/arm/plat-samsung/pwm.c
+++ b/arch/arm/plat-samsung/pwm.c
@@ -22,6 +22,7 @@
 
 #include <mach/map.h>
 
+#include <plat/cpu.h>
 #include <plat/regs-timer.h>
 
 struct pwm_device {
@@ -215,10 +216,24 @@ int pwm_config(struct pwm_device *pwm, int duty_ns, int period_ns)
 
 	tcmp = duty_ns / tin_ns;
 	tcmp = tcnt - tcmp;
-	/* the pwm hw only checks the compare register after a decrement,
-	   so the pin never toggles if tcmp = tcnt */
-	if (tcmp == tcnt)
-		tcmp--;
+
+	if (soc_is_s3c24xx()) {
+		/*
+		 * The S3C24XX PWM HW only checks the compare register after
+		 * a decrement, so the pin never toggles if tcmp = tcnt.
+		 */
+		if (tcmp == tcnt)
+			tcmp--;
+	} else {
+		/*
+		 * The other PWM HW checks the compare register after tcmp++
+		 * internally, so needs -2 for tcmp, and the actual period
+		 * which has been calculated by period_ns and tin_ns is same
+		 * with (tcnt + 1), so need to down count for tcnt register.
+		 */
+		tcmp = tcmp - 2;
+		tcnt--;
+	}
 
 	pwm_dbg(pwm, "tin_ns=%lu, tcmp=%ld/%lu\n", tin_ns, tcmp, tcnt);
 
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux