On Sat, 24 Mar 2012 15:19:50 +0530, Thomas Abraham <thomas.abraham@xxxxxxxxxx> wrote: > Add device tree based discovery support for max8997. > > Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> > Cc: Rajendra Nayak <rnayak@xxxxxx> > Cc: Rob Herring <rob.herring@xxxxxxxxxxx> > Cc: Grant Likely <grant.likely@xxxxxxxxxxxx> > Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx> > --- > .../devicetree/bindings/regulator/max8997-pmic.txt | 133 ++++++++++++++++++ > drivers/mfd/max8997.c | 73 ++++++++++- > drivers/regulator/max8997.c | 143 +++++++++++++++++++- > include/linux/mfd/max8997-private.h | 1 + > include/linux/mfd/max8997.h | 1 + > 5 files changed, 347 insertions(+), 4 deletions(-) > create mode 100644 Documentation/devicetree/bindings/regulator/max8997-pmic.txt > > diff --git a/Documentation/devicetree/bindings/regulator/max8997-pmic.txt b/Documentation/devicetree/bindings/regulator/max8997-pmic.txt > new file mode 100644 > index 0000000..90a730b > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/max8997-pmic.txt > @@ -0,0 +1,133 @@ > +* Maxim MAX8997 Voltage and Current Regulator > + > +The Maxim MAX8997 is a multi-function device which includes volatage and > +current regulators, rtc, charger controller and other sub-blocks. It is > +interfaced to the host controller using a i2c interface. Each sub-block is > +addressed by the host system using different i2c slave address. This document > +describes the bindings for 'pmic' sub-block of max8997. > + > +Required properties: > +- compatible: Should be "maxim,max8997-pmic". > +- reg: Specifies the i2c slave address of the pmic block. It should be 0x66. > + > +- max8997,pmic-buck1-dvs-voltage: A set of 8 voltage values in micro-volt (uV) > + units for buck1 when changing voltage using gpio dvs. Refer to [1] below > + for additional information. > + > +- max8997,pmic-buck2-dvs-voltage: A set of 8 voltage values in micro-volt (uV) > + units for buck2 when changing voltage using gpio dvs. Refer to [1] below > + for additional information. > + > +- max8997,pmic-buck5-dvs-voltage: A set of 8 voltage values in micro-volt (uV) > + units for buck5 when changing voltage using gpio dvs. Refer to [1] below > + for additional information. These are *really long* property names. Anything over 32 characters seems excessive to me. Other than that the binding looks good. g. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |