On Thu, Mar 29, 2012 at 10:23 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > Joerg Roedel wrote: >> >> On Fri, Mar 16, 2012 at 01:47:50PM -0700, Kukjin Kim wrote: >>> >>> Anyway Joerg, how do you want to handle this? Do you want to pick up >>> 1/2/3 all of them in your tree? If so, 2nd patch should be on top of >>> some samsung topic stuff. >> >> >> Since patch 2 only applies to the Samsung tree, it is best to carry >> this in your tree for merging. Feel free to add my Acked-by to patch 3. >> But any further patches for the Exynos IOMMU drivers should go through >> my tree after it is merged. >> > > Hi Joerg, > > Now that 1st and 2nd can be applied cleanly into latest mainline. But > unfortunately, I have no chance to send them to Linus now and I'm not sure > you can do it during this merge window. If it is possible, please keep going > on with my ack. > > KyongHo, just note, happens follwoing complaint with checkpatch, but I'm not > sure this should be fixed right now. I think, if required, we can fix it > later. > > ERROR: Macros with complex values should be enclosed in parenthesis > #698: FILE: arch/arm/mach-exynos/dev-sysmmu.c:64: > > +#define DEFINE_SYSMMU_RESOURCE(core, mem, irq) \ > + DEFINE_RES_MEM_NAMED(core##_PA_SYSMMU_##mem, SZ_4K, #mem), \ > + DEFINE_RES_IRQ_NAMED(core##_IRQ_SYSMMU_##irq##_0, #mem) > DEFINE_SYSMMU_RESOURCE macro defines 2 array elements. The replacement string must not be enclosed by parenthesis. > ERROR: Macros with complex values should be enclosed in parenthesis > #702: FILE: arch/arm/mach-exynos/dev-sysmmu.c:68: > > +#define SYSMMU_RESOURCE_DEFINE(core, ipname, mem, irq) \ > + SYSMMU_RESOURCE(core, ipname) { \ > + DEFINE_SYSMMU_RESOURCE(core, mem, irq) \ > + } > Ditto. > WARNING: quoted string split across lines > #914: FILE: arch/arm/mach-exynos/dev-sysmmu.c:259: > > + pr_err("%s: Failed to add device resources > for " > + "%s.%d\n", __func__, > It does not happened in the patch I posted and the email received also does not have such problem. I wonder why the "pr_err(..." line is split into 2 lines. Thank you for concerning :) KyongHo. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html